Minor fgen fixes #11
Merged
Minor fgen fixes #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `var_names(::GradTransform, [...])` and `all_names` for generating symbolic subgradient variables - Fix inversion operation in division when lower and upper bounds are the same - Add more support for higher variable indices - Add error for `binarize!` to assist in debugging - Add `split_div::Bool` argument to `factor`, which determines whether terms like `x/y` will remain as-is or get factored into `x * (1/y)` - Improve variable sorting so that, e.g., `x10` will not come before `x2` - Add `extract`, which can pull a subexpression out of a primal trace and substitute out auxiliary variables - Fix `fgen` bug that would use an incorrect subgradient variable
- Tests for division operations removed for `fgen`. Rules were written to match McCormick.jl, which was modified after this issue: PSORLab/McCormick.jl#69. This change only affects division by a negative McCormick object when the convex and concave relaxation values are not the same, but since `fgen` will be deprecated in v0.5, this issue in `fgen` is not planned to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
var_names(::GradTransform, [...])andall_namesfor generating symbolic subgradient variablesbinarize!to assist in debuggingsplit_div::Boolargument tofactor, which determines whether terms likex/ywill remain as-is or get factored intox * (1/y)x10will not come beforex2extract, which can pull a subexpression out of a primal trace and substitute out auxiliary variablesfgenbug that would use an incorrect subgradient variable